Fix assert types to accurately reflect implementation #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the assert typings to match node's assert module. This informs Typescript to narrow the type of the parameters, and allows values that are not strictly boolean. Also the previous typings indicated a string return value, but that doesn't seem to match the JS implementation.
Ideally this code should compile correctly, and correctly inform Typescript about the assertion being made:
Currently this doesn't compile correctly for various reasons, which are fixed in this PR.
note: The checklist says to run "npm run benchmark" but no such script exists.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct